Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FEEL Popup Links Configurable #1083

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Make FEEL Popup Links Configurable #1083

merged 4 commits into from
Nov 1, 2024

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Oct 17, 2024 •
edited
Loading

Proposed Changes

  • makes the links shown in the FEEL popup editor configurable
  • links can be configured by end user instead of being hard-coded in core properties panel

Depends on bpmn-io/properties-panel#382
Related to https://github.com/camunda/product-hub/issues/2070#issuecomment-2449888911

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Oct 17, 2024
@philippfromme philippfromme mentioned this pull request Oct 17, 2024
Merged
4 tasks
@nikku
Copy link
Member

nikku commented Oct 30, 2024

@philippfromme Please link this up to the overarching initiative ("link FEEL co-pilot"), is that https://github.com/camunda/product-hub/issues/2070?

@philippfromme
Copy link
Contributor Author

Follow-up to bpmn-io/properties-panel#382.

@philippfromme philippfromme marked this pull request as ready for review October 31, 2024 15:32
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Oct 31, 2024
@philippfromme philippfromme mentioned this pull request Nov 1, 2024
Merged
4 tasks
nikku
nikku reviewed Nov 1, 2024
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a changelog entry. Changes look good to me.

@philippfromme philippfromme merged commit 099f486 into main Nov 1, 2024
8 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 1, 2024
@philippfromme philippfromme deleted the add-feel-copilot-link branch November 1, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku left review comments

@jarekdanielak jarekdanielak Awaiting requested review from jarekdanielak

@barmac barmac Awaiting requested review from barmac

Assignees

@philippfromme philippfromme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippfromme @nikku